kou commented on code in PR #48867:
URL: https://github.com/apache/arrow/pull/48867#discussion_r2726067464
##########
cpp/src/gandiva/precompiled/time.cc:
##########
@@ -566,6 +566,27 @@ bool is_valid_time(const int hours, const int minutes,
const int seconds) {
seconds < 60;
}
+// Normalize sub-seconds value to milliseconds precision (3 digits).
+// Truncates if more than 3 digits are provided, pads with zeros if fewer than
3 digits
+FORCE_INLINE
+int32_t normalize_subseconds_to_millis(int32_t subseconds, int32_t num_digits)
{
Review Comment:
Can we define this in anonymous namespace? (If we can't use anonymous
namespace here, can we use `static` to hide this symbol?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
