scovich commented on code in PR #9270:
URL: https://github.com/apache/arrow-rs/pull/9270#discussion_r2729516637
##########
arrow-json/src/reader/struct_array.rs:
##########
@@ -81,28 +81,30 @@ pub struct StructArrayDecoder {
impl StructArrayDecoder {
pub fn new(
ctx: &DecoderContext,
- data_type: DataType,
+ data_type: &DataType,
is_nullable: bool,
) -> Result<Self, ArrowError> {
- let struct_mode = ctx.struct_mode();
- let fields = struct_fields(&data_type);
-
- // If this struct nullable, need to permit nullability in child array
- // StructArrayDecoder::decode verifies that if the child is not
nullable
- // it doesn't contain any nulls not masked by its parent
Review Comment:
https://github.com/apache/arrow-rs/pull/9271 merged too quickly... this
comment was supposed to remain inside the `.map` call. So I'm restoring this
code back to follow the original upstream approach, instead of opening a
separate PR just for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
