jhorstmann commented on code in PR #9268:
URL: https://github.com/apache/arrow-rs/pull/9268#discussion_r2731144406
##########
arrow-array/src/array/list_array.rs:
##########
@@ -418,18 +418,39 @@ impl<OffsetSize: OffsetSizeTrait>
GenericListArray<OffsetSize> {
T: ArrowPrimitiveType,
P: IntoIterator<Item = Option<<T as ArrowPrimitiveType>::Native>>,
I: IntoIterator<Item = Option<P>>,
+ {
+ Self::from_nested_iter::<T::Native, PrimitiveBuilder<T>, P, I>(iter)
+ }
+
+ /// Creates a [`GenericListArray`] from an iterator of primitive values
Review Comment:
Added a sentence about the supported types, and changed the example to use
more complicated type than `from_iter_primitive`.
I also reordered the generic parameters, in most cases only the builder type
needs to be specified, all others can be inferred. Still, its one more generic
than `from_iter_primitive`, so I would agree to keep that other method
un-deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
