rok commented on code in PR #48988:
URL: https://github.com/apache/arrow/pull/48988#discussion_r2731492751
##########
ci/scripts/python_wheel_validate_contents.py:
##########
@@ -33,6 +33,18 @@ def validate_wheel(path):
)
]
assert not outliers, f"Unexpected contents in wheel: {sorted(outliers)}"
+ license = [
+ info.filename for info in f.filelist if re.search(
+ r'LICENSE.txt$', info.filename
+ )
+ ]
+ assert license, "LICENSE.txt is missing from the wheel."
+ notice = [
+ info.filename for info in f.filelist if re.search(
+ r'NOTICE.txt$', info.filename
+ )
+ ]
+ assert notice, "NOTICE.txt is missing from the wheel."
Review Comment:
Nit:
```suggestion
for filename in ('LICENSE.txt', 'NOTICE.txt'):
assert any(info.filename.endswith(filename) for info in f.filelist), \
f"{filename} is missing from the wheel."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
