dmitry-chirkov-dremio commented on code in PR #49035:
URL: https://github.com/apache/arrow/pull/49035#discussion_r2733219078
##########
cpp/src/gandiva/precompiled/string_ops.cc:
##########
@@ -2252,6 +2252,11 @@ const char* right_utf8_int32(gdv_int64 context, const
char* text, gdv_int32 text
FORCE_INLINE
const char* binary_string(gdv_int64 context, const char* text, gdv_int32
text_len,
gdv_int32* out_len) {
+ if (text_len == 0) {
+ *out_len = 0;
+ return "";
Review Comment:
Java version is
[NullHandling.NULL_IF_NULL](https://github.com/dremio/dremio/blob/b4e8471ef73776ead16b6e56fc783f472d828434/oss/sabot/kernel/src/main/java/com/dremio/exec/expr/fn/impl/StringFunctions.java#L2081C15-L2081C40)
Are we going to return empty string for null? If so - that's inconsistency
we can't have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
