rluvaton commented on code in PR #9222:
URL: https://github.com/apache/arrow-rs/pull/9222#discussion_r2736088268
##########
arrow-row/src/lib.rs:
##########
@@ -3699,120 +3859,206 @@ mod tests {
t.join(",")
}
+ #[derive(Debug, PartialEq)]
+ enum Nulls {
+ /// Keep the generated array as is
+ AsIs,
+
+ /// Replace the null buffer with different null buffer to point to
different positions as null
+ Different,
+
+ /// Remove all nulls
+ None,
+ }
+
#[test]
#[cfg_attr(miri, ignore)]
fn fuzz_test() {
+ let mut rng = StdRng::seed_from_u64(42);
Review Comment:
Ideally I would say more test cases, BUT the impact if it starts to fail and
someone just rerun it, it will remove trust in the test and will be ignored or
just rerun to make the test pass rather than fixing the issue.
for example, think about some PR that updates a comment and this fails, so
the author will have less trust in this test and when that author will touch
arrow-row later in the future and that test fail again, they will just rerun
the CI rather than fix the bug.
Ideally you would bound the seed to the current PR so:
1. rerunning it will not help except creating a new PR which is less likely
2. you can still reproduce
but it will be less intuitive how to reproduce the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
