mzabaluev commented on code in PR #8930:
URL: https://github.com/apache/arrow-rs/pull/8930#discussion_r2736601816
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -499,6 +499,12 @@ mod header;
mod record;
mod vlq;
+#[cfg(feature = "async")]
+mod async_reader;
+
+#[cfg(feature = "async")]
+pub use async_reader::*;
Review Comment:
This re-exports `ReaderBuilder` ambiguously with the sync counterpart.
It's better to re-export only what needs to be public at that level by name.
```suggestion
pub use async_reader::{AsyncAvroFileReader, AsyncFileReader,
AvroObjectReader};
```
`async_reader::ReaderBuilder` is then left private, which is not a big issue
since it's instantiated from the `builder` associated fn. But to expose that
without ambiguity, I'd make `mod async reader` also public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
