alamb commented on a change in pull request #214:
URL: https://github.com/apache/arrow-datafusion/pull/214#discussion_r622908712
##########
File path: datafusion/src/sql/parser.rs
##########
@@ -21,7 +21,7 @@
use sqlparser::{
ast::{ColumnDef, ColumnOptionDef, Statement as SQLStatement,
TableConstraint},
- dialect::{keywords::Keyword, Dialect, GenericDialect},
+ dialect::{keywords::Keyword, Dialect, PostgreSqlDialect},
Review comment:
> make the dialect default to Postgres, but be configurable, with a doc
warning mentioning the potential risks and edge cases
I think this makes sense
> mention nullary functions as a replacement for scalar variables in SQL in
the next set of release notes
👍
> random bonus thought: maybe expose a unary function to retrieve scalar
variables by name from SQL?
This also sounds good -- if you wrote it up as a ticket, I bet it is a good
"first issue" type ticket for someone else in the community to do if they were
looking for something to learn DataFusion code a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
