Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r2766001043
##########
cpp/src/arrow/compute/kernels/select_k_test.cc:
##########
@@ -162,9 +165,11 @@ TYPED_TEST(TestSelectKForReal, Real) {
this->AssertSelectKJson("[null, 2, NaN, 3, 1]", 1);
this->AssertSelectKJson("[null, 2, NaN, 3, 1]", 2);
this->AssertSelectKJson("[null, 2, NaN, 3, 1]", 3);
- this->AssertSelectKJson("[null, 2, NaN, 3, 1]", 4);
+ // The result will contain nan. By default, the comparison of NaN is not
equal, so
Review Comment:
The tests are still working, I reverted the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
