crepererum commented on code in PR #628: URL: https://github.com/apache/arrow-rs-object-store/pull/628#discussion_r2769002099
########## src/local.rs: ########## Review Comment: Technically we could push this even further (maybe in a follow up): `read_at` doesn't modify the current read head at all. `seek_read` does, but the offset is always from the start of the file. So in both cases, you can read offsets from multiple threads in parallel. For a rotating disk this will probably not help (in contrary it might actually be counter-productive), but for an NVMe you can totally do that and in some cases get higher read throughput (esp. when your ranges are so tiny that the read latency is basically the bottleneck). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
