alamb commented on code in PR #9363:
URL: https://github.com/apache/arrow-rs/pull/9363#discussion_r2771409372
##########
arrow-string/src/length.rs:
##########
@@ -175,6 +176,18 @@ pub fn bit_length(array: &dyn Array) -> Result<ArrayRef,
ArrowError> {
vec![*len * 8; array.len()].into(),
array.nulls().cloned(),
)?)),
+ DataType::BinaryView => {
+ let list = array.as_binary_view();
+ let values = list
+ .views()
+ .iter()
+ .map(|view| (*view as i32).wrapping_mul(8))
Review Comment:
I think most other places use `u32` (rather than `i32`) -- for example
https://github.com/apache/arrow-rs/blob/6505d2a354e87e193e00ca7c6ea945de92c7adca/arrow-array/src/array/byte_view_array.rs#L372-L371
https://github.com/apache/arrow-rs/blob/6505d2a354e87e193e00ca7c6ea945de92c7adca/arrow-array/src/array/byte_view_array.rs#L339-L338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
