Divyanshu-s13 commented on PR #377: URL: https://github.com/apache/arrow-js/pull/377#issuecomment-3862233808
> Very nice. > > * I wonder whether we can do some kind of check whether a second instance of arrow exists. We could show a warning. Otherwise I'd worry that we will at some point run into issues where people have multiple versions of Arrow in their systems for a long time. > * What's the performance impact of these changes? This needs to be addressed before we can merge the changes. Great suggestions! 1. Multiple instance detection: I can add a version check that warns users when multiple Arrow versions are loaded. Will implement this. 2. Performance impact: The [Symbol.hasInstance] check is a simple property lookup ([x?.[kSymbol] === true] which should be O(1). I'll run benchmarks to measure: instanceof with vs without Symbol.hasInstance Impact on hot paths like Table iteration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
