rok commented on PR #49171: URL: https://github.com/apache/arrow/pull/49171#issuecomment-3864253300
This PR looks ok, however test looks AI generated so I checked the statement. It turns out `decimal` was not deprecated "over 6 years ago" but rather in November 2024 when 18.1.0 was released. PR for deprecation was merged on [4th September 2024](https://github.com/apache/arrow/pull/43957/changes#diff-79bec37f77fa174c78a55b17c75d71fe6b566b04e1fc82385f00b76ac908d63eR533). Since I don't want to search for every claim you make here, please do the following: * expand this PR to all C++ symbols you want to deprecate and rename it appropriately * provide PR links where deprecation notice was given (per symbol) and the release where this commit was then released e.g.: * `decimal` was deprecated on [4th September 2024](https://github.com/apache/arrow/pull/43957/changes#diff-79bec37f77fa174c78a55b17c75d71fe6b566b04e1fc82385f00b76ac908d63eR533) which was a part of 18.1.0 (November 2024). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
