Dandandan commented on code in PR #9297:
URL: https://github.com/apache/arrow-rs/pull/9297#discussion_r2779462418
##########
arrow-buffer/src/buffer/boolean.rs:
##########
@@ -141,15 +139,15 @@ impl BooleanBuffer {
/// input buffer.
///
/// # Notes:
- /// * The new `BooleanBuffer` has zero offset, even if `offset_in_bits` is
non-zero
+ /// * The new `BooleanBuffer` keeps the non-zero offset if not aligned by
byte and may have padding
Review Comment:
This is using bitwise_binary_op, so would not need to be changed as part of
this PR (but would be if we also change that implementation the same way).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
