alinaliBQ commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2784052991
##########
.github/workflows/cpp_extra.yml:
##########
@@ -530,11 +530,46 @@ jobs:
uses: actions/upload-artifact@v6
with:
name: flight-sql-odbc-msi-installer
- path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
+ path: build/cpp/Apache-Arrow-Flight-SQL-ODBC-*-win64.msi
if-no-files-found: error
+ - name: Install ODBC MSI
+ run: |
+ cd build/cpp
+ $odbc_msi = Get-ChildItem -Filter
"Apache-Arrow-Flight-SQL-ODBC-*-win64.msi"
+ if (-not $odbc_msi) {
+ Write-Error "ODBC MSI not found"
+ exit 1
+ }
+
+ foreach ($msi in $odbc_msi) {
+ Write-Host "Installing $($msi.Name) with logs"
+ $log = "odbc-install.log"
+ Start-Process msiexec.exe -Wait -ArgumentList "/i `"$msi`"",
"/qn", "/L*V `"$log`""
+ Get-Content $log
+ }
+ - name: Check ODBC DLL installation
+ run: |
+ $dirs = Get-ChildItem "C:\Program Files" -Directory -Filter
"Apache-Arrow-Flight-SQL-ODBC*"
+
+ foreach ($dir in $dirs) {
+ $bin = Join-Path $dir.FullName "bin"
+
+ if (Test-Path $bin) {
+ tree $bin /f
+
+ $dll = Join-Path $bin "arrow_flight_sql_odbc.dll"
+ if (Test-Path $dll) {
+ Write-Host "Found ODBC DLL: $dll"
+ exit 0
+ }
+ }
+ }
+
+ Write-Error "ODBC DLL not found"
+ exit 1
odbc-nightly:
- needs: odbc
+ needs: odbc-msvc
name: ODBC nightly
Review Comment:
This change should fix the c++ extra error, sorry I didn't catch this earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
