wgtmac commented on code in PR #49125:
URL: https://github.com/apache/arrow/pull/49125#discussion_r2783258634
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -694,17 +698,76 @@ Status MapToSchemaField(const GroupNode& group, LevelInfo
current_levels,
return Status::OK();
}
+Status ResolveList(const GroupNode& group, const Node& list_node,
+ LevelInfo current_levels, SchemaTreeContext* ctx,
+ const SchemaField* out, SchemaField* child_field) {
Review Comment:
It looks strange that `out` is const. Now that both `out` and `child_field`
are output parameters, should we rename them to `out_list_field` and
`out_elem_field` to be clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
