brunal commented on PR #7933: URL: https://github.com/apache/arrow-rs/pull/7933#issuecomment-3876602461
This isn't ready as-is: * aggregate works, but is inefficient for min-max: it goes through all values (cost `O(n*log(n))` for n values), when it could just look at the run-ends child array (cost `O(# runs)` < `O(n)`) * cmp only implements distinct, and is inefficient as well (binary searches for logical->physical index) I'll send a first PR just for aggregate, and later a second PR for cmp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
