Jefffrey commented on code in PR #9375:
URL: https://github.com/apache/arrow-rs/pull/9375#discussion_r2787316896
##########
parquet/tests/arrow_reader/io/mod.rs:
##########
@@ -244,6 +244,8 @@ struct TestParquetFile {
/// The operation log for IO operations performed on this file
ops: Arc<OperationLog>,
/// The (pre-parsed) parquet metadata for this file
+ // TODO: this is unused; consider removing it.
+ #[allow(dead_code)]
Review Comment:
Maybe for this dead code we can use it in a test somewhere to assert
something useful? 🤔
##########
parquet/src/arrow/schema/extension.rs:
##########
Review Comment:
```suggestion
//! Arrow [`ExtensionType`]s.
//!
//! Extension types are represented using the metadata from Arrow [`Field`]s
//! with the key "ARROW:extension:name".
//!
//! [`ExtensionType`]: arrow_schema::extension::ExtensionType
```
Maybe we can do it like this to keep it clean
##########
parquet/src/arrow/schema/extension.rs:
##########
Review Comment:
Maybe we could rebind in each of these arms like so?
```rust
let mut arrow_field = arrow_field;
```
I usually prefer to use `expect` instead of `allow` but we'd need to cfg it
with three different features here, so maybe its easier to just narrow the
`mut` scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
