rok commented on code in PR #48601:
URL: https://github.com/apache/arrow/pull/48601#discussion_r2789799294
##########
python/pyarrow/tests/conftest.py:
##########
@@ -49,28 +47,6 @@
os.environ['AWS_CONFIG_FILE'] = "/dev/null"
-if sys.platform == 'win32':
- tzdata_set_path = os.environ.get('PYARROW_TZDATA_PATH', None)
- if tzdata_set_path:
- set_timezone_db_path(tzdata_set_path)
-
-
-# GH-45295: For ORC, try to populate TZDIR env var from tzdata package resource
-# path.
-#
-# Note this is a different kind of database than what we allow to be set by
-# `PYARROW_TZDATA_PATH` and passed to set_timezone_db_path.
-if sys.platform == 'win32':
- if os.environ.get('TZDIR', None) is None:
- from importlib import resources
- try:
- os.environ['TZDIR'] = os.path.join(resources.files('tzdata'),
'zoneinfo')
Review Comment:
I suspect we don't really test for this as I believe ORC still needs TZDIR,
see https://github.com/apache/arrow/pull/48601#pullrequestreview-3717617913.
I'll do another check tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
