rluvaton commented on code in PR #9393:
URL: https://github.com/apache/arrow-rs/pull/9393#discussion_r2793161004
##########
arrow-ord/src/sort.rs:
##########
@@ -74,8 +74,9 @@ where
{
let sort_options = options.unwrap_or_default();
- let mut mutable_buffer = vec![T::default_value(); primitive_values.len()];
- let mutable_slice = &mut mutable_buffer;
+ let mut mutable_buffer =
+ MutableBuffer::from_len_zeroed(primitive_values.len() *
std::mem::size_of::<T::Native>());
Review Comment:
Note: this assume that `T::default_value()` is 0 which is the case, but I
verified by reading the code that it is just a placeholder so it is ok 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
