felipecrv commented on PR #3904: URL: https://github.com/apache/arrow-adbc/pull/3904#issuecomment-3887543036
> I'm not an expert on Rust lifetimes but this does seem like an improvement. My specific use case is writing a driver that doesn't have lifetime constraints on its readers (DataFusion) where I'm immediately exporting to FFI where the lifetime constraints are no longer enforced, so I'm probably a poor judge on both the use and author side of this. Your intuition is right! Returning an `impl` tied to the `Statement` object lifetime is too limiting. It only covers unit test cases where you create a statement, execute it and fully consume the reader without storing it anywhere else other than the stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
