trxcllnt commented on code in PR #379: URL: https://github.com/apache/arrow-js/pull/379#discussion_r2800638747
########## src/util/json.ts: ########## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// @ts-ignore +import jsonBigInt from 'json-bigint'; + +const parseJSON = jsonBigInt({ useNativeBigInt: true }).parse; Review Comment: The serialization part makes sense, but I was concerned about this: ```js o !== JSONbig.parse(JSONbig.stringify(o)) ``` It seems like if parse sometimes produces BitInt and other times Number, we'd have to know to always cast the numbers to BigInt after parsing and hope that the values that parsed as numbers didn't lose precision. That said, I think [this](https://github.com/sidorares/json-bigint/issues/88#issuecomment-1935464056) is a bigger issue. It sounds like we can't `JSONbig.parse()` any payloads that includes decimals, which seems problematic if parsing an ArrowJSON message with both a Float64 and IntervalMonthDayYear column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
