jhorstmann commented on code in PR #9407:
URL: https://github.com/apache/arrow-rs/pull/9407#discussion_r2803602892
##########
arrow-ord/src/sort.rs:
##########
@@ -216,27 +218,20 @@ fn partition_validity_scan(
let mut valid = Vec::with_capacity(len - null_count);
let mut nulls = Vec::with_capacity(null_count);
- unsafe {
- // 1) Write valid indices (bits == 1)
- let valid_slice = valid.spare_capacity_mut();
- for (i, idx) in bitmap.inner().set_indices_u32().enumerate() {
- valid_slice[i].write(idx);
- }
+ let mut cur_idx = 0u32;
- // 2) Write null indices by inverting
- let inv_buf = !bitmap.inner();
Review Comment:
Interesting, I think this was changed in the other direction in
https://github.com/apache/arrow-rs/commit/625e6ee41d9dc463c08490070278b2090e168e31#diff-2c3ee46148ccba8c1092294caab66ba73416314595ce2eef9b2bdd9cd898b27d
I wonder what changed now that makes the benchmarks go the other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
