Jefffrey commented on code in PR #9411:
URL: https://github.com/apache/arrow-rs/pull/9411#discussion_r2806876256
##########
arrow-buffer/src/buffer/null.rs:
##########
@@ -222,6 +222,14 @@ impl NullBuffer {
pub fn buffer(&self) -> &Buffer {
self.buffer.inner()
}
+ /// Create a [`NullBuffer`] from an *unsliced* validity bitmap (`offset =
0`) of length `len`.
+ ///
+ /// Returns `None` if there are no nulls (all values valid).
+ pub fn try_from_unsliced(buffer: impl Into<Buffer>, len: usize) ->
Option<Self> {
Review Comment:
Maybe we should call it `from_buffer`? `try_*` probably should be reserved
for functions that return a `result`, and its probably better to be direct that
we're constructing directly from a `buffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
