mzabaluev commented on code in PR #9397: URL: https://github.com/apache/arrow-rs/pull/9397#discussion_r2809032364
########## arrow-avro/benches/project_record.rs: ########## @@ -0,0 +1,239 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use apache_avro::types::Value; +use apache_avro::{Schema as ApacheSchema, to_avro_datum}; Review Comment: I just copied it over from another benchmark. I personally think it's OK for generating with another implementation, but if the writer is ready, I can replace it. I think it more expedient to update all benchmarks at once, though. So if such a change lands in main before this PR is merged, I would sync with it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
