k8ika0s commented on PR #49282: URL: https://github.com/apache/arrow/pull/49282#issuecomment-3910917155
> Can you please clear what actual problem are you solving? > > > Using near-max bounds can hit allocator-specific fatal behavior (especially with mimalloc) > > Can or does? Did you hit such a case? If so, why is it an issue? Good question, especially with the overly strong wording I used... the real issue was test instability/long-running behavior from using near-max synthetic allocation sizes, especially on large-memory s390x environments. the test intent is to verify Arrow’s OutOfMemory path, not allocator-specific extreme-size internals. the mimalloc skip is only for this synthetic giant-size path; I can drop the skip and keep only the clamp if that’s preferred. I mentioned s390x, which is part of a larger focus. I know there is previous open and closed work around s390x, but with upstream support stalling, my goal here is to take much smaller bite size approach to begin addressing issues still in the latest codebase. I would also agree that this change on its own seems like a very cheap attempt to get a contrib, which is not the intent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
