pitrou commented on PR #49300: URL: https://github.com/apache/arrow/pull/49300#issuecomment-3919162868
> Not for this PR but we should consider using a pattern that is more explicitly about why we are doing the cast, so future code doesn't repeat similar mistakes. Yes, that is a common concern accross the Parquet codebase. Part of that is historical design of the codebase I think, and part is due to Thrift metadata where many sizes are encoded as int32 rather than int64 (even though Thrift uses zig-zag encoding, so it probably wouldn't make a difference size-wise...). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
