miraclx commented on code in PR #652:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/652#discussion_r2872681297


##########
src/parse.rs:
##########
@@ -178,8 +178,6 @@ pub fn parse_url(url: &Url) -> Result<(Box<dyn 
ObjectStore>, Path), super::Error
 ///   Note different object stores accept different configuration options, so
 ///   the options that are read depends on the `url` value. One common pattern
 ///   is to pass configuration information via process variables using
-///   [`std::env::vars`]. Keys must be lower-case and match the list of 
supported

Review Comment:
   Fixed, thanks!



##########
src/aws/builder.rs:
##########
@@ -546,7 +546,6 @@ impl AmazonS3Builder {
     ///
     /// All environment variables starting with `AWS_` will be evaluated.
     /// Names must match acceptable input to [`AmazonS3ConfigKey::from_str`].
-    /// Only upper-case environment variables are accepted.

Review Comment:
   No, only AWS incorrecly mentions this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to