rok commented on code in PR #49427:
URL: https://github.com/apache/arrow/pull/49427#discussion_r2880338030
##########
python/scripts/run_emscripten_tests.py:
##########
Review Comment:
As per claude `threading.Thread.terminate` doesn't exists, but this is not
really an issue here.
##########
python/setup.py:
##########
@@ -126,6 +126,9 @@ def run(self):
def _update_stubs(self):
"""Copy stubs to build directory, then inject docstrings into the
copies."""
+ if is_emscripten:
+ # stubs are not supported in Emscripten build
+ return
Review Comment:
Makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
