jecsand838 commented on code in PR #9462:
URL: https://github.com/apache/arrow-rs/pull/9462#discussion_r2880520764
##########
arrow-avro/src/reader/async_reader/builder.rs:
##########
@@ -109,8 +109,18 @@ impl<R> ReaderBuilder<R> {
}
}
-impl<R: AsyncFileReader> ReaderBuilder<R> {
- async fn read_header(&mut self) -> Result<(Header, u64), AvroError> {
+impl<R> ReaderBuilder<R>
Review Comment:
> `Header` is not currently public, but this could be just an oversight. Its
interface looks public-ready.
No it wasn't an oversight. We didn't make `Header` public because Avro OCF
must have a Header to be valid per the
[spec](https://avro.apache.org/docs/1.11.1/specification/#object-container-files).
Therefore, we didn't see any scenario where the caller ever needs to directly
use the `Header`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
