alinaliBQ commented on code in PR #49220:
URL: https://github.com/apache/arrow/pull/49220#discussion_r2885907861
##########
cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt:
##########
@@ -25,29 +25,57 @@ set(ARROW_FLIGHT_SQL_MOCK_SERVER_SRCS
../../example/sqlite_server.cc
../../example/sqlite_tables_schema_batch_reader.cc)
+set(ARROW_FLIGHT_SQL_ODBC_TEST_SRCS
+ odbc_test_suite.cc
+ odbc_test_suite.h
+ columns_test.cc
+ connection_attr_test.cc
+ connection_info_test.cc
+ connection_test.cc
+ errors_test.cc
+ get_functions_test.cc
+ statement_attr_test.cc
+ statement_test.cc
+ tables_test.cc
+ type_info_test.cc
+ # Enable Protobuf cleanup after test execution
+ # GH-46889: move protobuf_test_util to a more common location
+ ../../../../engine/substrait/protobuf_test_util.cc)
+
+if(ARROW_TEST_LINKAGE STREQUAL "static")
+ set(ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS arrow_flight_sql_odbc_static
+ ${ARROW_TEST_STATIC_LINK_LIBS})
+else()
+ set(ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS arrow_flight_sql_odbc_shared
+ ${ARROW_TEST_SHARED_LINK_LIBS})
Review Comment:
I needed to replace `ARROW_TEST_LINK_LIBS` with `ARROW_TEST_< STATIC |
SHARED >_LINK_LIBS` here, because `ARROW_TEST_LINK_LIBS` contains unneeded
variables and was causing linking issues. I based my code change on here:
https://github.com/apache/arrow/blob/cfbbf708082c84f3a7cb1246d83ef134c2ac27c4/cpp/src/arrow/acero/CMakeLists.txt#L110-L114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
