lidavidm commented on code in PR #4046: URL: https://github.com/apache/arrow-adbc/pull/4046#discussion_r2886739066
########## javascript/LICENSE.txt: ########## Review Comment: Technically, the JavaScript module's license should only need to include attribution for stuff it actually uses (the transitive dependencies of the Rust driver manager), for things shipped in the binary. (If the NPM upload includes sources of transitive JavaScript dependencies, we should include those licenses too.) ########## ci/scripts/node_build.sh: ########## @@ -0,0 +1,59 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e + +# Usage: ./node_build.sh <out_dir> +if [ "$#" -ne 1 ]; then + echo "Usage: $0 <out_dir>" + exit 1 +fi + +REPO_ROOT=$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd) +OUT_DIR="$1" + +# 1. Build the C++ Drivers +echo "=== Building C++ Drivers ===" +mkdir -p "${OUT_DIR}" + +# On macOS, the system sqlite3.h omits sqlite3_load_extension. The cmake +# auto-detection has a bug (string(FIND) returns -1 which is truthy in +# cmake's if(), so the NO_LOAD_EXTENSION guard is never set). Pass it +# explicitly on macOS to avoid a compilation error. +if [[ "$(uname)" == "Darwin" ]]; then + ADBC_CMAKE_ARGS="${ADBC_CMAKE_ARGS} -DADBC_SQLITE_COMPILE_DEFINES=-DADBC_SQLITE_WITH_NO_LOAD_EXTENSION" +fi Review Comment: Ideally we just fix that in the CMake itself given it's in the same repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
