raulcd commented on code in PR #49436: URL: https://github.com/apache/arrow/pull/49436#discussion_r2889278535
########## cpp/src/arrow/flight/sql/server.cc: ########## @@ -537,7 +537,9 @@ arrow::Result<std::string> CreateStatementQueryTicket( ticket_statement_query.set_statement_handle(statement_handle); google::protobuf::Any ticket; - ticket.PackFrom(ticket_statement_query); + // PackFrom returns void for older protobuf versions and [[nodiscard]] bool + // for newer versions, so we explicitly ignore the return value. + (void)ticket.PackFrom(ticket_statement_query); Review Comment: that's a good idea! Let me try this and validate it builds for C++ and then try pinning protobuf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
