maltzsama opened a new pull request, #145:
URL: https://github.com/apache/arrow-swift/pull/145
## Summary
This PR includes two targeted fixes to improve correctness and usability of
the arrow-swift package:
### 1. Fix 64-byte buffer alignment calculation
- **File**: `Sources/Arrow/ArrowBuffer.swift`
- **Change**: Removed erroneous `+8` padding from `alignTo64()` function
- **Impact**:
- Ensures strict compliance with Arrow IPC specification (64-byte
alignment)
- Reduces memory waste (approximately 8 bytes per buffer)
- Prevents potential IPC incompatibility with other Arrow implementations
### 2. Expose ArrowFlight as public library product
- **File**: `Package.swift`
- **Change**: Added `.library(name: "ArrowFlight", targets:
["ArrowFlight"])` to products array
- **Impact**:
- Downstream packages can now `import ArrowFlight` when depending on
arrow-swift
- Resolves issue where ArrowFlight target existed but was not importable
## Testing
- `swift build` succeeds
- Existing unit tests pass
- Verified ArrowFlight module is now resolvable in dependent package
- Validated buffer alignment with IPC round-trip test
## Related Issues
- Closes #115
- Addresses alignment concern raised in #114 discussion
## Breaking Changes
None. Both changes are backward-compatible:
- Buffer alignment fix only affects internal memory layout (no API change)
- ArrowFlight exposure adds new public product without modifying existing
ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
