raulcd commented on PR #49476: URL: https://github.com/apache/arrow/pull/49476#issuecomment-4032706572
> I consulted with 🤖 and perhaps we should switch to `_lib.__file__` in `create_library_symlinks` and `get_library_dirs` too. I am unsure about that, the problem happens for editable builds where scikit-build-core seems to be pushing the files to python site-packages instead of in the source tree. `create_library_symlinks` seems to be only necessary to be executed when building extensions and pyarrow has been installed from wheels (not editable is expected here). The files on that case should be at the current location. https://arrow.apache.org/docs/python/integration/extending.html#building-extensions-against-pypi-wheels We might have to revisit whether `create_library_symlinks` is still required to build extensions (might not be relevant anymore). As per the other change on `get_library_dirs`, I also don't think it is required, those changes are for Windows delvewheel embedded msvcp140.dll and for bundled Arrow C++ those should be at the requested location. Editable builds don't apply for those cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
