paleolimbot commented on code in PR #4050: URL: https://github.com/apache/arrow-adbc/pull/4050#discussion_r2920338852
########## c/include/arrow-adbc/adbc.h: ########## @@ -1977,26 +1977,41 @@ AdbcStatusCode AdbcConnectionGetInfo(struct AdbcConnection* connection, /// /// The result is an Arrow dataset with the following schema: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | catalog_name | utf8 | -/// | catalog_db_schemas | list<DB_SCHEMA_SCHEMA> | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | catalog_name | utf8 | | +/// | catalog_db_schemas | list<DB_SCHEMA_SCHEMA> | | +/// | remarks | utf8 | (1) | +/// +/// 1. [Since version 1.2.0] A description of the catalog. This field is +/// optional. /// /// DB_SCHEMA_SCHEMA is a Struct with fields: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | db_schema_name | utf8 | -/// | db_schema_tables | list<TABLE_SCHEMA> | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | db_schema_name | utf8 | | +/// | db_schema_tables | list<TABLE_SCHEMA> | | +/// | remarks | utf8 | (1) | +/// +/// 1. [Since version 1.2.0] A description of the schema. This field is +/// optional. /// /// TABLE_SCHEMA is a Struct with fields: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | table_name | utf8 not null | -/// | table_type | utf8 not null | -/// | table_columns | list<COLUMN_SCHEMA> | -/// | table_constraints | list<CONSTRAINT_SCHEMA> | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | table_name | utf8 not null | | +/// | table_type | utf8 not null | | +/// | table_columns | list<COLUMN_SCHEMA> | | +/// | table_constraints | list<CONSTRAINT_SCHEMA> | | +/// | table_definition | utf8 | (1) | +/// | remarks | utf8 | (2) | +/// Review Comment: We had chatted in the previous issue about adding a serialized Arrow schema here. I don't love the idea of putting Arrow IPC stuffed in a deeply tested Arrow C Array but I'm also in a very small minority of people who is aware of or cares how many lines of code are required to parse it 🙂 . If you'd like to add it it does seem like a good opportunity to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
