davidhcoe commented on PR #4075: URL: https://github.com/apache/arrow-adbc/pull/4075#issuecomment-4056644752
> Note we noticed various inconsistencies in profiles that we're working on correcting (#4082 / #4085) I added some items to address #4082. For #4085 , based on your table, this implementation currently does: Feature -> How It Works - init_func (entrypoint) priority -> LoadDriver(path, entrypoint) - if provided, uses it directly - Load driver from explicit path -> LoadDriver(driverPath) - Load driver by name (search) -> FindLoadDriver(driverName, ...) with directory search - Load from profile object -> OpenDatabaseFromProfile(profile, ...) - Profile from TOML file -> TomlConnectionProfile.FromFile(path) - Explicit options override profile -> OpenDatabaseFromProfile(profile, explicitOptions, ...) - Managed (.NET) drivers -> LoadManagedDriver(assemblyPath, typeName) - Native drivers -> Via CAdbcDriverImporter.Load(...) - Co-located manifests (.toml next to .dll) -> Auto-detected in LoadDriver - Profile/manifest version fields -> profile_version (new) and version (legacy) - Options section naming -> [Options] (new) and [options] (legacy, case-insensitive) ❌ Not Yet Implemented - URI parsing -> No parsing of snowflake://..., postgresql://... URIs - Profile URI scheme -> No profile:///path/to/file.toml support - Driver URI scheme -> No URI that embeds both driver and connection string - Profile in options -> No automatic detection of profile key in options dict - Multiple profile detection -> No error if profile specified in multiple ways - Driver/profile consistency -> No validation that driver arg matches profile's driver - URI extraction from driver -> No parsing driver argument as potential URI - Non-driver URI detection -> No distinguishing connection URIs from driver URIs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
