jgiannuzzi opened a new pull request, #662:
URL: https://github.com/apache/arrow-rs-object-store/pull/662
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #661.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
See issue.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Add `close_file()` helper that calls `libc::close()` (Unix) /
`CloseHandle` (Windows) directly and propagates errors, instead of relying on
`File::drop()`. Note that this uses `unsafe`, like in the platforms' respective
`drop()` implementations.
- Add `with_sync_on_close(bool)` builder method on `LocalFileSystem` that
calls `File::sync_all()` before closing, providing stronger durability
guarantees for network filesystems.
- Apply both to the `put` and `put_multipart` (via `LocalUpload`) code paths.
- Add `libc` (Unix) and `windows-sys` (Windows) as optional dependencies
behind the `fs` feature for their respective platforms.
- Duplicate the existing integration test to also run with
`sync_on_close(true)`. Note that this doesn't "do" anything and is just there
to validate that the additional behaviour does not create issues.
- Add unit test verifying `close_file` detects `EBADF` when the file
descriptor is closed behind Rust's back. This is just to validate that
`close_file` properly returns the OS error.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
New public API: `LocalFileSystem::with_sync_on_close(bool) -> Self`. Default
is `false` (no behaviour change for existing users).
Close errors are now detected and propagated as
`Error::UnableToCopyDataToFile`. Previously these were silently ignored. This
is a correctness improvement but could surface errors that were previously
hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
