lesam opened a new pull request, #716: URL: https://github.com/apache/arrow-go/pull/716
Add 'take' and 'filter' implementations for dictionary arrays. These implementations simply filter/take on the index column and shallow-copy the dictionary. https://github.com/apache/arrow-go/issues/714 ### Rationale for this change It would be nice for 'take' and 'filter' to work for all array encodings, including dictionary ### What changes are included in this PR? Just 'take' and 'filter' implementations and an addition to the tests ### Are these changes tested? Unit tests added ### Are there any user-facing changes? These will now work instead of failing with an error like: ``` not implemented: function 'array_filter' has no kernel matching input types (dictionary<values=utf8, indices=int8, ordered=false>, bool) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
