alamb commented on PR #643: URL: https://github.com/apache/arrow-rs-object-store/pull/643#issuecomment-4091244908
I don't think we should automatically call fsync on filesystem writes. Users who want that behavior can already call `fsync` when the write returns. An option (defaulting to false) would make sense for convenience > There is also the question to me of what happens if a process is writing lots of files to the same directory, fsyncing the directory on every new file is rather wasteful, you really want some mechanism for the caller to fsync as part of some higher-level transaction. I think it be best put in a layer higher up in the call stack (whatever is calling / orchestrating this higher level transaction using the `object_store` crate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
