lidavidm commented on code in PR #4125: URL: https://github.com/apache/arrow-adbc/pull/4125#discussion_r2964336399
########## javascript/src/client.rs: ########## Review Comment: Is a brand-new IPC reader for every message going to handle things like dictionaries properly? (I guess it would merely be very redundant, we'd send the dictionaries on every message?) In theory an Arrow implementation could expose the underlying IPC message so you can turn a stream of data into a stream of messages (instead of a stream of serialized files/streams), but I'm not sure if arrow-js + arrow-rs can do this That said as long as it works we can always improve later... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
