lyang24 commented on PR #9093: URL: https://github.com/apache/arrow-rs/pull/9093#issuecomment-4104754688
implemented @Dandandan 's suggestions over the issue and ran changes again locally a couple of times this looks promising locally | Category | Benchmark | Branch (µs) | Master (µs) | Change | |------------------|--------------------------------------------|------------|------------|--------| | StringArray | plain, mandatory, no NULLs | 631 | 614 | +2.8% | | StringArray | plain, optional, no NULLs | 617 | 636 | -3.0% | | StringArray | plain, optional, half NULLs | 466 | 485 | -3.9% | | StringArray | dict, mandatory, no NULLs | 412 | 415 | -0.7% | | StringArray | dict, optional, no NULLs | 427 | 410 | +4.1% | | StringArray | dict, optional, half NULLs | 381 | 376 | +1.3% | | StringArray | const prefix delta byte array, mandatory | 897 | 890 | +0.8% | | StringArray | const delta byte array, mandatory | 657 | 655 | +0.3% | | StringArray | const delta length byte array, mandatory | 493 | 472 | +4.4% | | BinaryArray | plain, mandatory, no NULLs | 557 | 584 | -4.6% | | BinaryArray | plain, optional, no NULLs | 636 | 570 | +11.6% | | BinaryArray | plain, optional, half NULLs | 423 | 468 | -9.6% | | BinaryArray | dict, mandatory, no NULLs | 413 | 407 | +1.5% | | BinaryArray | dict, optional, no NULLs | 409 | 408 | +0.2% | | BinaryArray | dict, optional, half NULLs | 351 | 359 | -2.2% | | BinaryViewArray | plain, mandatory, short string | 114 | 119 | -4.2% | | BinaryViewArray | plain, mandatory, no NULLs | 123 | 127 | -3.1% | | BinaryViewArray | plain, optional, no NULLs | 126 | 129 | -2.3% | | BinaryViewArray | plain, optional, half NULLs | 119 | 129 | -7.8% | | BinaryViewArray | dict, mandatory, no NULLs | 54 | 62 | -12.9% | | BinaryViewArray | dict, optional, no NULLs | 56 | 63 | -11.1% | | BinaryViewArray | dict, optional, half NULLs | 89 | 90 | -1.1% | | StringDictionary | dict, mandatory, no NULLs | 196 | 203 | -3.4% | | StringDictionary | dict, optional, no NULLs | 199 | 204 | -2.5% | | StringDictionary | dict, optional, half NULLs | 221 | 230 | -3.9% | | StringViewArray | plain, mandatory, no NULLs | 150 | 155 | -3.2% | | StringViewArray | plain, optional, no NULLs | 155 | 159 | -2.5% | | StringViewArray | plain, optional, half NULLs | 131 | 140 | -6.4% | | StringViewArray | dict, mandatory, no NULLs | 54 | 61 | -11.5% | | StringViewArray | dict, optional, no NULLs | 56 | 62 | -9.7% | | StringViewArray | dict, optional, half NULLs | 88 | 100 | -12.0% | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
