asubiotto commented on PR #9621:
URL: https://github.com/apache/arrow-rs/pull/9621#issuecomment-4141810940
Unfortunately did not see there is an open PR #9448 before working on this,
however I think this PR is more complete since #9448 does not seem to support
REE with scalar or mixed comparisons. Also, this PR is more performant:
```
PR #9448 (REE-vs-REE only, panics on REE-vs-scalar):
ree_comparison/eq_ree_ree(phys=64,log=65536) time: [2.5053 µs
2.5281 µs 2.5516 µs]
ree_comparison/lt_ree_ree(phys=64,log=65536) time: [2.5559 µs
2.5783 µs 2.6024 µs]
ree_comparison/eq_ree_ree(phys=1024,log=65536) time: [9.6708 µs
9.7004 µs 9.7291 µs]
ree_comparison/lt_ree_ree(phys=1024,log=65536) time: [9.4187 µs
9.4457 µs 9.4717 µs]
ree_comparison/eq_ree_ree(phys=32768,log=65536) time: [225.23 µs
228.23 µs 232.46 µs]
ree_comparison/lt_ree_ree(phys=32768,log=65536) time: [200.61 µs
201.16 µs 201.81 µs]
Ours:
ree_comparison/eq_ree_scalar(phys=64,log=65536) time: [449.04 ns
456.42 ns 464.89 ns]
ree_comparison/lt_ree_scalar(phys=64,log=65536) time: [447.29 ns
449.15 ns 451.32 ns]
ree_comparison/eq_ree_ree(phys=64,log=65536) time: [425.39 ns
426.91 ns 428.48 ns]
ree_comparison/lt_ree_ree(phys=64,log=65536) time: [439.47 ns
440.59 ns 441.69 ns]
ree_comparison/eq_ree_flat(phys=64,log=65536) time: [46.541 µs
46.659 µs 46.783 µs]
ree_comparison/eq_ree_scalar(phys=1024,log=65536) time: [4.4344 µs
4.4435 µs 4.4543 µs]
ree_comparison/lt_ree_scalar(phys=1024,log=65536) time: [5.3170 µs
5.6797 µs 6.1374 µs]
ree_comparison/eq_ree_ree(phys=1024,log=65536) time: [4.7932 µs
4.8049 µs 4.8183 µs]
ree_comparison/lt_ree_ree(phys=1024,log=65536) time: [5.7911 µs
6.7388 µs 7.8086 µs]
ree_comparison/eq_ree_flat(phys=1024,log=65536) time: [51.404 µs
52.651 µs 54.233 µs]
ree_comparison/eq_ree_scalar(phys=32768,log=65536) time: [94.964 µs
95.714 µs 96.556 µs]
ree_comparison/lt_ree_scalar(phys=32768,log=65536) time: [95.557 µs
96.428 µs 97.527 µs]
ree_comparison/eq_ree_ree(phys=32768,log=65536) time: [137.23 µs
139.33 µs 141.49 µs]
ree_comparison/lt_ree_ree(phys=32768,log=65536) time: [105.79 µs
106.37 µs 107.20 µs]
ree_comparison/eq_ree_flat(phys=32768,log=65536) time: [143.00 µs
215.04 µs 340.63 µs]
```
cc @alamb @Jefffrey @brunal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
