VersusFacit opened a new pull request, #4155:
URL: https://github.com/apache/arrow-adbc/pull/4155

   ## Summary
   
   Fix Rust `driver_manager` search-path loading for bare driver names.
   
   This came up while testing local ADBC driver development through additional 
search paths. We've used this plenty over the past year or so. However, now 
`search_path_list()` in `rust/driver_manager/src/search.rs` was joining a bare 
driver name like `adbc_driver_bigquery` directly into the search directory and 
attempting to load that path as-is. On macOS, that meant trying 
`/path/to/adbc_driver_bigquery` instead of 
`/path/to/libadbc_driver_bigquery.dylib`.
   
   This change applies `libloading::library_filename(...)` before loading from 
additional search paths so path-based search matches the existing by-name 
loading behavior.
   
   This also, I believe, aligns the Rust behavior with the existing C++ 
driver-manager search-path logic in 
`c/driver_manager/adbc_driver_manager_driver_loading.cc`, where 
`ManagedLibrary::SearchPathsForDriver()` removes the manifest suffix and relies 
on `Load(...)` to add the platform library suffix during path-based search.
   
   ## Testing
   
   `cargo +1.86 test -p adbc_driver_manager 
test_load_additional_path_with_platform_library_filename`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to