lidavidm commented on code in PR #731:
URL: https://github.com/apache/arrow-go/pull/731#discussion_r3005671487
##########
parquet/internal/utils/unpack_bool_neon_arm64.s:
##########
@@ -12,76 +11,137 @@ TEXT ยท_bytes_to_bools_neon(SB), $0-32
MOVD out+16(FP), R2
MOVD outlen+24(FP), R3
- // The Go ABI saves the frame pointer register one word below the
- // caller's frame. Make room so we don't overwrite it. Needs to stay
- // 16-byte aligned
Review Comment:
Worth preserving this explanatory comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
