kou commented on code in PR #153:
URL: https://github.com/apache/arrow-swift/pull/153#discussion_r3007082187
##########
Package.swift:
##########
@@ -70,6 +71,11 @@ let package = Package(
.testTarget(
name: "ArrowTests",
dependencies: ["Arrow", "ArrowC"],
+ resources: [
+ .copy("testdata_bool.arrow"),
+ .copy("testdata_double.arrow"),
+ .copy("testdata_struct.arrow")
Review Comment:
Can we copy them from `../../data-genrator/swift-datagen/`?
##########
.gitignore:
##########
@@ -35,3 +35,7 @@ xcuserdata/
# Release
/apache-arrow-swift-*.tar.gz*
/dev/release/.env
+
+# Generated test data
+Tests/ArrowTests/*.arrow
+data-generator/swift-datagen/*.arrow
Review Comment:
Could you prepend `/` like others?
##########
.github/workflows/test.yaml:
##########
@@ -113,3 +113,37 @@ jobs:
github.ref_name == 'main'
run: |
docker compose push ubuntu
+
+ ios:
+ name: iOS
+ runs-on: macos-15
+ timeout-minutes: 15
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #
v6.0.2
+ - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 #
v5.5.0
+ with:
+ go-version: "stable"
+ - name: Generate test data
+ run: |
+ cd data-generator/swift-datagen
+ go run .
+ cp *.arrow ../../Tests/ArrowTests/
+ - name: Select iOS Simulator
+ run: |
+ SIMULATOR_ID=$(xcrun simctl list devices available 2>/dev/null | \
Review Comment:
Could you add a comment that shows example output of `xcrun ...` and each
filter something like the following?
```yaml
# Example:
# (xcrun ... output)
# ->
# (awk ... output)
# ->
# (sort ... output)
# ->
# (head -1 output)
# ->
# (grep ... output)
```
It'll help us when the command line doesn't work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
