jding-xyz commented on code in PR #152:
URL: https://github.com/apache/arrow-swift/pull/152#discussion_r3007339260
##########
Sources/Arrow/ArrowData.swift:
##########
@@ -26,9 +26,17 @@ public class ArrowData {
public let stride: Int
convenience init(_ arrowType: ArrowType, buffers: [ArrowBuffer],
nullCount: UInt) throws {
+ let arrayLength: UInt
+ switch arrowType.info {
+ case .variableInfo:
+ arrayLength = max(buffers[1].length, 1) - 1
Review Comment:
Modified as suggested. Also updated checkHolderForType in the test to
provide spec-compliant dummy buffers for variable-width types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
