felipecrv commented on code in PR #4141:
URL: https://github.com/apache/arrow-adbc/pull/4141#discussion_r3017559672


##########
rust/core/src/error.rs:
##########
@@ -102,10 +102,26 @@ impl Error {
 
 impl Display for Error {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        let safe_ascii = |c: c_char| -> char {
+            if c == 0 {
+                '0'

Review Comment:
   But this is because drivers can either set the SQLSTATE to all 0 integers or 
'0' ASCII. They are all equivalent to the end-user: they mean "empty SQLSTATE".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to