alamb commented on a change in pull request #258:
URL: https://github.com/apache/arrow-rs/pull/258#discussion_r626732147
##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -380,6 +380,18 @@ impl<T: DataType> ArrayReader for PrimitiveArrayReader<T> {
}
Arc::new(builder.finish()) as ArrayRef
}
+ ArrowType::UInt64 => match array.data_type() {
Review comment:
I was thinking of the additional copy that comes from the `arity` call
-- specifically
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/arity.rs#L64
The `arity` call will be in addition to any copying that `cast` does, I
think.
Also, when the types are the same, then cast is a
[noop](https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/cast.rs#L300)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
