sdf-jkl commented on code in PR #9663:
URL: https://github.com/apache/arrow-rs/pull/9663#discussion_r3082777093
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -321,12 +328,19 @@ impl<'a> VariantToShreddedArrayVariantRowBuilder<'a> {
// If the variant is not an array, typed_value must be null.
// If the variant is an array, value must be null.
match variant {
- Variant::List(list) => {
+ Variant::List(ref list) => {
self.nulls.append_non_null();
- self.value_builder.append_null();
- self.typed_value_builder
- .append_value(&Variant::List(list))?;
- Ok(true)
+
+ // With `safe` cast option set to false, appending list of
wrong size to
+ // `typed_value_builder` of type `FixedSizeList` will result
in an error. In such a
+ // case, the provided list should be appended to the
`value_builder.
Review Comment:
True. I think the core issue is that Parquet currently has only one logical
`LIST` type. If Parquet had a dedicated logical type for `FixedSizeList`, the
spec wording could be more explicit.
Btw, there’s ongoing work on this too:
https://github.com/apache/parquet-format/pull/241 (recently revived).
Given the current spec text:
```
Arrays can be shredded by using a 3-level Parquet list for typed_value.
If the value is not an array, typed_value must be null. If the value is an
array, value must be null.
```
I read “array” as "a value matching the specific list shape we’re shredding
into". For `List`/`LargeList`/`ListView` it's `List` values, for
`FixedSizeList` array it's a `FixedSizeList` value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
